[18.09 BACKPORT] Pick a random host port if the user does not specify a host port. #2369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For overlay, l2bridge, and l2tunnel, if the user does not specify a host port, windows driver will select a random port for them. This matches linux behavior. For ics and nat networks the windows OS will choose the port. Signed-off-by: Pradip Dhara <pradipd@microsoft.com> Signed-off-by: Madhu Venugopal <madhu@docker.com>
|
Can you change the title to use |
mavenugo
changed the title
|
backport of #2368 |
thaJeztah
added a commit
to thaJeztah/docker
that referenced
this pull request
Apr 23, 2019
full diff: moby/libnetwork@c902989...872f0a8 - moby/libnetwork#2354 [18.09 backport] Cleanup the cluster provider when the agent is closed - backport of moby/libnetwork#2307 Fix for problem where agent is stopped and does not restart - fixes docker/for-linux#495 Docker swarm overlay networking not working after --force-new-cluster - moby/libnetwork#2369 [18.09 BACKPORT] Pick a random host port if the user does not specify a host port - backport of moby/libnetwork#2368 (windows) Pick a random host port if the user does not specify a host port Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
docker-jenkins
pushed a commit
to docker-archive/docker-ce
that referenced
this pull request
Apr 23, 2019
full diff: moby/libnetwork@c902989...872f0a8 - moby/libnetwork#2354 [18.09 backport] Cleanup the cluster provider when the agent is closed - backport of moby/libnetwork#2307 Fix for problem where agent is stopped and does not restart - fixes docker/for-linux#495 Docker swarm overlay networking not working after --force-new-cluster - moby/libnetwork#2369 [18.09 BACKPORT] Pick a random host port if the user does not specify a host port - backport of moby/libnetwork#2368 (windows) Pick a random host port if the user does not specify a host port Signed-off-by: Sebastiaan van Stijn <github@gone.nl> Upstream-commit: 5354408039681020f9ad6afe4bf696fc90f9ce69 Component: engine
buildroot-auto-update
pushed a commit
to buildroot/buildroot
that referenced
this pull request
May 7, 2019
Additional post-18.09.5 fixes: Builder: - Fixed COPY and ADD with multiple <src> to not invalidate cache if DOCKER_BUILDKIT=1.moby/moby#38964 Networking: - Cleaned up the cluster provider when the agent is closed. moby/libnetwork#2354 - Windows: Now selects a random host port if the user does not specify a host port. moby/libnetwork#2369 - --service-cluster-ip-range is now configurable for UCP install. docker/orca#10263 Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
buildroot-auto-update
pushed a commit
to buildroot/buildroot
that referenced
this pull request
May 7, 2019
Additional post-18.09.5 fixes: Builder: - Fixed COPY and ADD with multiple <src> to not invalidate cache if DOCKER_BUILDKIT=1.moby/moby#38964 Networking: - Cleaned up the cluster provider when the agent is closed. moby/libnetwork#2354 - Windows: Now selects a random host port if the user does not specify a host port. moby/libnetwork#2369 - --service-cluster-ip-range is now configurable for UCP install. docker/orca#10263 Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
buildroot-auto-update
pushed a commit
to buildroot/buildroot
that referenced
this pull request
May 10, 2019
Additional post-18.09.5 fixes: Builder: - Fixed COPY and ADD with multiple <src> to not invalidate cache if DOCKER_BUILDKIT=1.moby/moby#38964 Networking: - Cleaned up the cluster provider when the agent is closed. moby/libnetwork#2354 - Windows: Now selects a random host port if the user does not specify a host port. moby/libnetwork#2369 - --service-cluster-ip-range is now configurable for UCP install. docker/orca#10263 Signed-off-by: Peter Korsgaard <peter@korsgaard.com> (cherry picked from commit d692ecb) Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
buildroot-auto-update
pushed a commit
to buildroot/buildroot
that referenced
this pull request
May 10, 2019
Additional post-18.09.5 fixes: Builder: - Fixed COPY and ADD with multiple <src> to not invalidate cache if DOCKER_BUILDKIT=1.moby/moby#38964 Networking: - Cleaned up the cluster provider when the agent is closed. moby/libnetwork#2354 - Windows: Now selects a random host port if the user does not specify a host port. moby/libnetwork#2369 - --service-cluster-ip-range is now configurable for UCP install. docker/orca#10263 Signed-off-by: Peter Korsgaard <peter@korsgaard.com> (cherry picked from commit c7e5f9c) Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
ghost
reviewed
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For overlay, l2bridge, and l2tunnel, if the user does not specify a host port, windows driver will select a random port for them. This matches linux behavior.
For ics and nat networks the windows OS will choose the port.
Signed-off-by: Pradip Dhara pradipd@microsoft.com
Signed-off-by: Madhu Venugopal madhu@docker.com